`toRelativeCalendar` doesn't really work like you'd expect

This is a little funny:

base = DateTime.local(2018, 12, 31);
base.plus({ days: 1 }).toRelativeCalendar({base}) //=> "next year"

This is technically correct, but I suspect most people would want that to say “tomorrow”. Same issue with the end of months.

The question is: when should it say next year?

1. whenever it is next year? (current behavior)
2. never?
3. When it’s over 1 year in the future? (this is pretty weird IMO; in our 12/31 example, it would only say “next year” for one day at the end of next year")
4. when it’s over N months in the future? For what N?

Same problem for months. And I haven’t even introduced weeks, which is surely similar.

[icambron]

Yes, we need a spec. I like the idea that the threshold matches the size of the unit. I don’t like the idea of overrides because I think it would be a confusing API. We can always add it later but we can’t take it back once we do. So I’d like to make this change without expanding the API surface area.

I don’t think this really requires a major version bump, either.

[Doaa-Ismael]

It happens with me also … Is there any plan to fix it?