Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

URL broken in install instructions

See original GitHub issue

It links to here which is 404: https://moment.github.io/luxon/es6/luxon.min.js

https://moment.github.io/luxon/docs/manual/install.html#es6

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

AdaRoseCannoncommented, Sep 19, 2020

Yeah, uglify can’t handle ES6. I believe Terser is the modern minifier à la mode.

On Sat, 19 Sep 2020, 22:29 Isaac Cambron, notifications@github.com wrote:

@AdaRoseCannon https://github.com/AdaRoseCannon I took a quick look. It turns out that uglify is choking on the es6 syntax trying to minify it. I probably took it out rather than figure out the tooling issue. In general, Luxon is overdue for a tooling overhaul, but if you’re game to give a shot, you can enable it by adding minify: true to the es6 part of tasks/build.js. It gives me this error:

Building es6

Error uglifying JS_Parse_Error [SyntaxError]: Unexpected token: name «LuxonError», expected: punc «;»
at JS_Parse_Error.get (eval at <anonymous> (/Users/isaaccambron/code/luxon/node_modules/uglify-js/tools/node.js:18:1), <anonymous>:71:23)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moment/luxon/issues/771#issuecomment-695357898, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAHSMVRH7UJCCBN2ZOEHILSGUPEHANCNFSM4RLOG4NA .

0reactions

icambroncommented, Oct 3, 2020

Yeah, if that worked, I’ll take a PR