Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
(GitHub Issue Comments) The script no longer works: it shows invalid active items, no active items and the filters don't actually toggle anything
See original GitHub issueGreetings @Mottie !
Using Chrome 78/Firefox 70 and only Tampermonkey beta 4.9.6088 and ‘GitHub Issue Comments’ v1.3.8.
After GitHub recently having changed so many class names, unfortunately the ‘GitHub Issue Comments’ script no longer works:
- it shows invalid active items when ‘Toggle items’ is disabled
- it shows no active items when ‘Toggle items’ is enabled
- the filters don’t actually hide/show anything in any case.
There are no errors in Chrome Console.
I’ve tried various issue pages:
https://github.com/Mottie/GitHub-userscripts/issues/104
https://github.com/Mottie/GitHub-userscripts/issues/84
https://github.com/openstyles/stylus/issues/55
https://github.com/isaacs/github/issues/895
and in all cases, the above issues occur.
Also, the filters, in the rare cases when one is listed as active with ‘Toggle items’ enabled (e.g. in the first link its ‘Reactions’), don’t actually toggle anything when clicked.
Could it be possible to make it work again?? May I assist you in any way with this?
If I’m not mistaken, unfortunately it’s not a simple matter of just tweaking the CSS selectors.
( Maybe they should all be replaced with jQuery :contains() (specific string) selectors ?? )
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:12 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Ok, please check again. I misnamed the function, so hide +1 & reactions were both broken. Both should be fixed now. 🤞
Ok, I think I fixed most of the issues; but I’m not happy with how the reviews are working.
Reviews are sometimes wrapped in an outer wrapper that includes a timeline comment with code comments. Sometimes the review wrapper includes other changes like commits and other timeline changes.
So now there are new/updated review entries:
Reviews (All)- hides all reviews. This also includes review requests, approvals and change requests.Reviews (Outdated)- hides only outdated reviews; but may include current reviews depending on the wrapper.Reviews (Resolved)- hides only resolved reviews, which usually means they are outdated. Also may include other reviews depending on the groupingReviews (Current)- hides only current reviews; but again it may include other review types…I also ended up removing the “Diffs (outdated) comments” entry since it has become redundant with “Review (outdated)”.