GitHub remove diff signs: not all files get their signs removed

Hello, I just found the “GitHub remove diff signs” userscript, thanks for making it.

But it seems to have a bug, the + and - signs doesn’t get removed from all files in the “Files changed” tab of some pull requests.

Here’s an example with 6 files: https://github.com/Mottie/tablesorter/pull/195/files the signs have been removed from the first 5 files, but they are still shown in the last file: js/jquery.tablesorter.js.

And here’s another example with 17 files: https://github.com/Mottie/tablesorter/pull/1293/files the signs have been removed from the first 3 files, but they are still there from the 4th file: js/widgets/widget-filter-formatter-html5.js down.

Here’s an example with 4 files. The first two files are hidden until one clicks on them: https://github.com/Mottie/Keyboard/pull/363/files the first one says:

“Load diff Large diffs are not rendered by default.”

and the second file says:

“Load diff Some generated files are not rendered by default. Learn more.”

The signs on the last 2 files are shown. When one clicks on the first 2 files to show their diffs, then the signs are still visible on them as well.

The script seems to work fine on the pull requests I’ve seen with only 1 or 2 files.

System info

Windows 10 1607 (OS Build 14393.953) Google Chrome 56.0.2924.87 (Official Build) (32-bit) Tampermonkey v4.2.7 GitHub Remove Diff Signs 1.0.2

[Mottie]

I just added a How to wiki page with my current take on how I deal with GitHub and progressively loaded content. Let me know what you guys think.

[jerone]

All examples on this page are working for me too now 🎉