question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

(GitHub Sort Reactions) Third click on 'sort by +1' and 'speak no evil monkey' avatar icons doesn't restore the comment order in some cases

See original GitHub issue

STR In a clean Chrome 65 profile with only Tampermonkey 4.6.5752 beta installed and GSR script v0.2.2:

case 1

open https://github.com/gorhill/uMatrix/issues/928 and click on the ‘speak no evil monkey’ avatar sort icon 3 times: notice that the comment order is not restored. With all other avatar sort icons, the comment order is restored ok.

cases 2, 3

In https://github.com/gorhill/uMatrix/issues/968 or https://github.com/gorhill/uMatrix/issues/567, if you click 3 times either the ‘speak no evil monkey’ avatar icon or the ‘sort by +1’ avatar icon , the initial comment order is not restored. With the other avatar sort icons, the comment order is restored ok.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
Mottiecommented, May 8, 2018

Sorry for taking so long to get this fixed!

1reaction
Mottiecommented, May 8, 2018

Hi @darkred!

Eww yuck! Thanks for reporting this problem. I’ll try to look into it soon…

Read more comments on GitHub >

github_iconTop Results From Across the Web

GitHub sort reactions · Mottie/GitHub-userscripts Wiki
Clicking on a sort reaction button or avatar sort icon will sort the comments by the selected reaction: "+1", "-1", "laugh", "hooray", "confused"...
Read more >
Lots of Ways to Use Math.random() in JavaScript - CSS-Tricks
Math.random(); // returns a random number lower than 1. This is incredibly useful for gaming, animations, randomized data, generative art, ...
Read more >
Git pull: error: Entry foo not uptodate. Cannot merge
gitignore file outside the repository (as a sort of "backup") and then did a git reset --hard , which "fixed" the repository into...
Read more >
zxcvbn-async.js - Drupal
diff --git a/core/assets/vendor/zxcvbn/zxcvbn-async.js ... d.sort(function(b,a){return b.i-a.i||b.j-a.j})};N=function(b,a){var d,c,e,f,g,h,i,j,k;h=[] ...
Read more >
Canvas Developers Group - Instructure Community
I've developed a tool I wanted to share here. I teach multiple sections of a course with up to 72 students per section....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found