500 error page (in development) when add-on recommendation service is down

Describe the problem and steps to reproduce it:

• Do something in the recommendations saga to trigger abortFetchRecommendations(). For example, if the API is down, the saga would abort with this error:

Error calling: /api/v3/addons/recommendations/ (status: 500)

• Load any add-on detail page

What happened?

A 500 page is shown

What did you expect to happen?

The add-on detail page should be shown without any recommendations.

Anything else we should know?

The 500 page is caused by this component error:

Caught application error: Invariant Violation: "outcome is required"

See https://github.com/mozilla/addons-frontend/blob/4cbac1c586e49936e3a1327332e9d942d6b0e71e/src/amo/components/AddonRecommendations/index.js#L92

This will only affect development since invariant() doesn’t throw in production (it does throw 👻 ). I’m not sure what would happen in production but the tracking event will be strange at the very least.

This only happened to me while hot reloading so that may be a prerequisite. Low priority issue but nice to fix!

[bobsilverberg]

• the only available GA I see (when an add-on detail page is loaded) in the console is [GA: ON] sendEvent {"hitType":"event","eventCategory":"AMO Addon / Recommendations Shown","eventAction":"recommended_fallback-timeout","eventLabel":"Turlink"}

I don’t know if that’s the event you are referring to. Let me know if there’s something else I should be checking.

No, that’s everything. Thanks!

[ioanarusiczki]

@bobsilverberg

• I did not find regressions on the frontend pages - the recommended badge is available.
• I could add/remove the recommended badge for an add-on.
• the only available GA I see (when an add-on detail page is loaded) in the console is [GA: ON] sendEvent {"hitType":"event","eventCategory":"AMO Addon / Recommendations Shown","eventAction":"recommended_fallback-timeout","eventLabel":"Turlink"}

I don’t know if that’s the event you are referring to. Let me know if there’s something else I should be checking. Thanks!