Expose more properties for theme install

For themes, we only expose a fraction of properties compared to what we used to in the old frontend.

Example: https://addons.mozilla.org/en-US/firefox/addon/pixel-bears/ , see property data-browsertheme of the install button.

For QA: please test for regressions related to all theme functionality. This includes theme detail pages, previewing, and installation in both AMO and the Discovery Pane.

Old frontend:

"accentcolor": "#"
"author": "Star_Shine"
"category": "Other"
"description": ""
"detailURL": "https://addons.mozilla.org/en-US/firefox/addon/pixel-bears/"
"footer": "https://addons.cdn.mozilla.net/user-media/addons/357219/2.jpg?1326075809"
"footerURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/2.jpg?1326075809"
"header": "https://addons.cdn.mozilla.net/user-media/addons/357219/Myhellokitty.jpg?1326075809"
"headerURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/Myhellokitty.jpg?1326075809"
"iconURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/preview_small.jpg?1326075809"
"id": "357219"
"name": "Pixel bears"
"previewURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/preview_large.jpg?1326075809"
"textcolor": "#ffffff"
"updateURL": "https://versioncheck.addons.mozilla.org/en-US/themes/update-check/357219"
"version": "1.0"

New frontend:

"accentcolor": "#"
"author": "Star_Shine"
"description": null
"footerURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/2.jpg?1326075809"
"headerURL": "https://addons.cdn.mozilla.net/user-media/addons/357219/Myhellokitty.jpg?1326075809"
"id": "357219"
"name": "Pixel bears"
"textcolor": "#ffffff"

As far as I can see, this data is used by Firefox, for example to set the favicon in the Add-ons Manager and to set the updateURL, which is important for static themes. Optimally, we would expose the same properties as in the old frontend.

Marking P2 on @jvillalobos’ request.

[wagnerand]

This might have been fixed. I could not reproduce any scenario where installing a theme does not add an icon to the add-on manager.

@kumar303 I can still reproduce.

STR using example: https://addons.mozilla.org/en-US/firefox/addon/xmas-02-paillette/

1. Install using the old frontend:
2. Go to the Add-ons Manager

vs.

1. Install using the new frontend:
2. Go to the Add-ons Manager

@ValentinaPC

we are talking about static themes, yes?

For now, we don’t. Eventually, it should be supported when static themes are ready too.

what icon do you talk about? this one:

Yes, the icon in the Add-ons Manager; also see above screenshots.

[kumar303]

I thought we had a bug on file for the disappearing icon behavior but I can’t find it.

found it https://github.com/mozilla/addons-frontend/issues/3014 😃