question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Loading indicators aren't show when switching between landing pages

See original GitHub issue

Sorry I didn’t catch this when doing local testing, I must not have noticed as I was on a fast enough connection that blinking would hide the fact that no loading bars appeared.

Describe the problem and steps to reproduce it:

If you are on a landing page (/extensions/ or /themes/) then navigate to the other landing page, loading indicators are not shown and the old content remains until the new content is loaded from the server.

What happened?

The old content remains until the new content loads.

What did you expect to happen?

There to be an intermediate loading state while the route changes but the load is taking place.

Screencasts

2017-08-01 23 06 15

Loading animation happens on first landing page load, but not on subsequent loads:

2017-08-01 23 06 35

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
kumar303commented, Aug 15, 2017

Yeah, the loading attribute controls the loading indicators (the blurry lines) but also the presence of each set of add-ons, i.e. state.featured. I think the thing to do is reset each set of add-ons when a new request gets started. For example:

diff --git a/src/amo/reducers/landing.js b/src/amo/reducers/landing.js
index 6c159823..7fa7272b 100644
--- a/src/amo/reducers/landing.js
+++ b/src/amo/reducers/landing.js
@@ -18,7 +18,7 @@ export default function landing(state = initialState, action) {
   switch (action.type) {
     case LANDING_GET:
       return {
-        ...state,
+        ...initialState,
         addonType: payload.addonType,
         loading: true,
         resultsLoaded: false,
0reactions
ValentinaPCcommented, Aug 17, 2017

Verified this on AMO-dev FF54(Win 7). Loading indicators are shown almost everywhere. While loading Extensions homepage coming from Explore the indicators are not shown. Things seem to work as expected while coming back from Themes. Is this ok, @muffinresearch ? Please see video: loading-indic

Read more comments on GitHub >

github_iconTop Results From Across the Web

63 Post-Click Landing Page Optimization Techniques Proven ...
Get the best post-click landing page optimization techniques proven to generate conversions. Sections include page design, headlines, copy, media, ...
Read more >
Best way to show Landing or Dashboard Page, based on ...
Hi, when a user visits my index page / i want to check, whether a current user exists or not. If a user...
Read more >
Increase Your Landing Page Speed (By Stealing ... - Unbounce
We've done the research so that you don't have to. Improve your landing page load times with this list of easy-to-understand speed fixes....
Read more >
How to have AJAX trigger the browser's loading indicator
The idea with this answer is to create an iframe on the page, with the iframe src pointing to a page that loads...
Read more >
Crucial Landing Page Metrics You Should Track to Increase ...
Your landing page looks perfect, but how well is it converting? These landing page metrics will help you monitor and analyze its ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found