question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] Don't allow and Allow buttons cannot be accessed in landscape mode

See original GitHub issue

Steps to reproduce

  1. Launch Fenix.
  2. Access Private browsing(make sure search suggestions are on).
  3. Type anything in the URL bar.
  4. The Allow search suggestions in private session? prompt is displayed.
  5. Rotate the device from portrait to landscape mode.

Expected behavior

The screen is scrollable and the Don't allow and Allow buttons can be accessed.

Actual behavior

The bottom part of the Allow search suggestions in private session? prompt is not displayed and Don't allow and Allow buttons cannot be accessed.

Device information

  • Android device: Google Pixel 3a XL(Android 10), OnePlus 6T(Android 9)
  • Fenix version: Latest Nightly 12/9.

ezgif-6-733c1fa8e9ce

UX

Design Work

  • Request for Comments from UX team
  • ~Usability testing if a new pattern or potentially confusing UI~ Not required – it’s a bugfix
  • Request for Comments from Fenix team and/or A/C, GV, Sync, etc as needed
  • Interaction details included
  • Accessibility ~- is this a review by someone,~ just keeping it in mind?
  • ~For existing UI changes, deltas are highlighted~ No UI – this is a behaviour change
  • the[ ] ~Strings/content reviewed and approved~ No string – this is a behaviour change
    • ~Are they too long for the component in other locales~

Deliverable

  • ~Assets uploaded to Google Drive~
  • ~Links to deliverables (spec, assets) posted in comment 0~

Deliverable Links

  • ~User flow: (link to e.g. Abstract artboard, LucidChart, Whimsical, Miro, etc.)~
  • ~Spec: (link to e.g. Abstract artboards)~
  • ~Assets: (link to Google Drive folder)~

Behaviours

We’ve tried designing new landscape-specific layouts for this dialogue. In the end, the solution that worked without introducing any layout exceptions is to make the search results scrollable. This is the behaviour that we should have.

┆Issue is synchronized with this Jira Task

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:22 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
jl-robertscommented, Apr 13, 2020

Even if dismissing keyboard on scroll worked, some devices won’t have that ability currently.

One Plus 7 Pro / Gboard with “Normal” keyboard height gives me no scroll area in landscape.

Screenshot_20200413-163053

1reaction
hackertronixcommented, Dec 18, 2019

Hey @mcarare yes I am working on this I will most probably open a PR early tomorrow morning.

Read more comments on GitHub >

github_iconTop Results From Across the Web

In iPhone landscape mode(game), my option…
1. Press and hold either volume button and the side button until the power-off slider appears.
Read more >
Landscape Mode Errors - android - Stack Overflow
1 Answer 1 ; LinearLayout xmlns:android · "http://schemas.android.com/apk/res/android" ; Button android:id · "@+id/LogIn_Button_Normal" ; Button ...
Read more >
Can't Select “Option” On Guided Access After Upgrading to ...
When I open the YT Kids app and enable the guided access (by pressing the home button 3x) I'm unable to select the...
Read more >
iOS 16 Guided Access is BROKEN! [Triple Click NOT Working]
If you enjoy this content, please consider a paid "super thanks" in the video or becoming a "member": ...
Read more >
iPhone Screen Not Rotating to Landscape Mode? Here's How ...
Can't put your iPhone in landscape mode despite rotating? Follow these troubleshooting steps to fix the issue.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found