question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[SPIKE] Evaluate ability to have non-browser tabs in the tabs tray

See original GitHub issue

For https://github.com/mozilla-mobile/fenix/issues/14117, we want to have Synced Tabs be a separate tab option in the tabs tray.

With the current tabs tray, we fake switching to two different tabs tray using the TabsFeature.defaultTabsFilter to filter between the two types. Now that we want to switch between other non-browser tab data, we should do this better:

A list of things to consider if it’s worth doing:

  • Refactor the tabs tray to have separate views for each browser tab type.
  • Use a ViewPager2 to switch between the multiple sources.
  • Move multi-select to be re-useable for the above items. We could potentially use the RecyclerView selection library here as well.

Break these out into separate issues where needed.

┆Issue is synchronized with this Jira Task

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:4
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
jonalmeidacommented, Oct 19, 2020

I’m happy to move this forward if there are no other comments and there are no other considerations to make. Will file new breakdown issues and put this into the backlog to pick up next.

0reactions
jonalmeidacommented, Feb 4, 2021

I’m going to close this with all the issues I’ve filed so far. You can find the full list of issues on this board: https://github.com/mozilla-mobile/fenix/projects/38

Read more comments on GitHub >

github_iconTop Results From Across the Web

Tabs Tray - GitHub
This meta is all about implementing the new tabs tray in Fenix. Tabs tray screen flow · Tab tray visual design.
Read more >
Manage tabs in Firefox for Android - Mozilla Support
Learn how to manage your tabs in the latest version of Firefox for Android. ... tab icon next to the address bar to...
Read more >
Is the tab tray really that bad in Firefox Fenix? Just curious to ...
Less to do with the tab tray's design in specific, but still "in" the tray: ... Being able to select multiple tabs would...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found