Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken CSS Build in pdfjs-dist (v2.15.349)

See original GitHub issue

Configuration

PDF.js version: v2.15.349

What went wrong? (add screenshot)

There seems to be a new image import images/toolbarButton-editorInk.svg in

I can find this svg file in the pdfjs github page assets, but neither pdfjs-dist/legacy/web/images nor pdfjs-dist/web/images are updated with the svg file in v2.15.349.

It is causing weird build issue on pdfjs-dist.

Issue Analytics

State:
Created a year ago
Comments:7 (1 by maintainers)

Top GitHub Comments

4reactions

phloosecommented, Aug 17, 2022

Sorry, but I don’t consider this CSS-only issue serious enough to warrant creating a new release immediately

Hmm this means, you consider a failing build for a lot of users not serious enough to release a new version that fixes this issue?! Sounds a bit harsh to me… What is the culprit here? What would take so much time to make sure the file exists or the path is correct? A patch for this would surely help a lot of users

4reactions

donaruscommented, Aug 6, 2022

Sorry, but I would disagree. I agree that it would not make sense to release the new version with all the other (and potentially untested) features and fixes. But on the other side, this may be blocking issues for many other related projects and the fix could be created from the actual release branch just patching it by adding the mentioned file to the correct place and rerelease it for example under 2.15.400 or 2.15.349.2. But if this solution is not a way, tell me a reason why please.

Until fixed, we figured out how to get over it by using the simple hack for NPM based builds:

package.json

{
  ...
  "scripts": {
    .....
    "postinstall": "node postinstall-fixes.js"
  },
  ...
}

postinstall-fixes.js

const file = fs.createWriteStream("./node_modules/pdfjs-dist/legacy/web/images/toolbarButton-editorInk.svg");
const request = https.get("https://raw.githubusercontent.com/mozilla/pdf.js/edc9ad13bf8f422f9495c4ede9bb9989969326e4/web/images/toolbarButton-editorInk.svg", function(response) {
   response.pipe(file);
   file.on("finish", () => {
       file.close();
   });
});

But still, it would make sense to fix this issue because many others would need to solve it somehow.