Migrate bots to GitHub Actions
See original GitHub issuePDF.js has two dedicated bots for testing. However, this is all custom and maintained manually. This is already a problem now since the bots run quite old OS versions that lack a (modern enough) Python 3 version, which blocks the ttx
upgrade for example (see #11802).
We could unblock this work by upgrading the OS versions, but for the longer term it would be better for the project to move towards a managed solution such as GitHub Actions. The latter integrates well with GitHub and our existing jobs, and reading quickly through the docs might allow us to create a botio
-like flow where whitelisted users can comment on PRs to trigger actions (builds).
In terms of our builds, I mainly see a challenge for the browser tests since they are stateful, so we need to be able to fetch/store the reference images somewhere. I’m thinking this could be done in an S3 bucket, and let GitHub manage the credentials for that.
Let’s investigate if these solutions could work for us and how much logic we have to maintain ourselves. The objective is to use existing solutions as much as possible so we don’t have to build/maintain it ourselves, as well as improving reliability.
Issue Analytics
- State:
- Created 3 years ago
- Comments:15 (14 by maintainers)
Top GitHub Comments
@timvandermeij I’ve added an s3 bucket. I’ve also added the following repository secrets:
AWS_ACCESS_KEY_ID AWS_REGION AWS_S3_BUCKET AWS_SECRET_ACCESS_KEY
Yeah, we should be able to do that. Let me look into getting it set up.