question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Regression] Highlighting of search results broken in some cases, after PR 13306

See original GitHub issue

Attach (recommended) or Link to PDF file here: https://github.com/tesseract-ocr/tesseract/files/947838/2.pdf

Configuration:

  • Web browser and its version: N/A
  • Operating system and its version: N/A
  • PDF.js version: 2.9.223, or any version after PR #13306 landed.
  • Is a browser extension: N/A

Steps to reproduce the problem:

  1. Open the document above, e.g. with https://mozilla.github.io/pdf.js/web/viewer.html
  2. Search for “of the r”

What is the expected behavior? (add screenshot) Correct highlighting, please see:

correct

What went wrong? (add screenshot) Incorrect highlighting, please see:

incorrect

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension): N/A

/cc @brendandahl

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
CetinSertcommented, May 28, 2021

I did my due diligence and report my findings here https://github.com/mozilla/pdf.js/issues/13396. No big deal if closed because PR #12896 is an improvement for most other documents.

I do sincerely apologize for temporarily derailing this issue.

0reactions
Snuffleupaguscommented, May 28, 2021

Do you (all devs of PDF.js) think #13345 (comment) qualifies for its own issue?

Probably not, given that this is the result of PR #12896 which is an overall improvement for most documents.


Note that as mentioned in the first paragraph of https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md, we try to limit each issue to just one problem since otherwise it becomes very difficult to track issues efficiently.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Loki search preview highlighting is broken #16277 - GitHub
This used to work, and the main purpose of the feature is to test regexps matching on the existing results before actually running...
Read more >
[debbugs-tracker] Unanswered problem reports by maintainer and ...
The following problem reports have not yet been marked as `done' by a ... bug when searching (End of file during parsing) gnus...
Read more >
Highlighting | Elasticsearch Guide [8.5] | Elastic
Highlighters enable you to get highlighted snippets from one or more fields in your search results so you can show users where the...
Read more >
NEWS · 6c29e81051bd622b22fbf057a6344dd66098cc0a · GNOME ...
GTK is a multi-platform toolkit for creating graphical user interfaces. ... in some cases 759705 Sidebar broken in GNOME Disks 759738 wayland: use...
Read more >
CHANGELOG · shuaigewei168/nmap - Gitee.com
o [GH#293][Zenmap] Fix a regression in our build that caused copy-and-paste to. not work in Zenmap on Windows. o Changed Nmap's idea of...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found