IntelliJ 2018.1 highlights that 'val' variables should have 'final' modifier

Short description

After upgrade to IntelliJ 2018.1 and latest Lombok Plugin available from plugin repository I’m getting IDE highlights on variables marked with ‘val’, that they don’t have ‘final’ modifier (IDEA inspection ‘Local variable or parameter can be final’).

Expected behavior

No variable highlighting and IDE correctly reads ‘val’ as having ‘final’ modifier.

Version information

• IDEA Version: IntelliJ IDEA 2018.1 (Ultimate Edition) Build #IU-181.4203.550, built on March 27, 2018
• JDK Version: Oracle JDK 1.8.0_152
• OS Type & Version: both Win10 and Win7
• Lombok Plugin Version: 0.17-2018.1
• Lombok Dependency Version: 1.16.20

Steps to reproduce

1. Enable inspection ‘Local variable or parameter can be final’ in IDE
2. Create Java class with any method containing something like val x = new Object();
3. IDE highlights variable ‘x’ as not having ‘final’ modifier. (See also attached screenshot)

Sample project

Please provide a sample project that exhibits the problem. You should also include .idea folder so we can inspect the settings.

• Sample project provided valissue.zip
• I am able to reproduce this error on the sample project by following the steps described above

[kossmoboleat]

Yes, the workaround seems to work for the inspection, but it doesn’t for usage in combination with the “save actions” plugin, because that one doesn’t seem to respect the checkmark.

Also by using this workaround, we’re then not getting the correct the correct inspection result for that try-with-resources case mentioned in the youtrack issue. I wrote there again, but I’m also not that knowledgeable if the check I proposed there is the way to go.

[MaximilianWiedemann]

I experience the same problem. Unfortunately, this also leads to other problems when using lombok’s val in combination with other plugins like “SaveActions” that seem to rely on the suggestions offered by IntelliJ. Since the 2018.1 update, SaveActions automatically applies the final keyword before val which was definitely not the case before.