question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

3MFLoader needs async handling of JSZip

See original GitHub issue
Description of the problem

3MF Loader relies on JSZip(data) constructor, but newer versions of JSZip use loadAsync.

Three.js version

[x] r86

Browser

[x] All of them

OS
  • All of them
Hardware Requirements (graphics card, VR Device, …)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:9 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
Mugen87commented, Sep 22, 2019

But I think less blocking the main thread by offloading this type of heavy processing like decoding/encoding is getting popular

Just to clarify: Because it’s async it does not mean the code is executed in a worker. The code is still executed in the main thread.

Apart from that, what would be the benefits of an upgrade? Does it fix a bug? Or performance issue? I does not seem so.

As long as there is no compelling reason, I would not perform a change which does result in migration effort for the user.

1reaction
mrdoobcommented, Jul 19, 2017

Seems like we’ll have to stay with an old version or switch to a library that allows synchronous.

Read more comments on GitHub >

github_iconTop Results From Across the Web

javascript - How to force function to await for jszip.loadAsync ...
I`m relatively new to js and async/await stuff. ... const jszip = require('jszip') const fs = require('fs') async function Backup(path) ...
Read more >
generateAsync(options[, onUpdate])
generateAsync (options[, onUpdate]). Generates the complete zip file at the current folder level. Returns : A Promise of the generated zip file.
Read more >
Optimizing 3D Object Visualization on the Web | SpringerLink
This study aims to develop a loader and a web visualizer for the 3MF format, and test its performance across desktop and mobile...
Read more >
更新three.js 版本 (e4b406b9) · 提交 · 林义丰 / panelsTest · GitLab
TOUCH_DOLLY_PAN ) return; // is this needed? ... ThreeMFLoader: jszip missing and file is compressed.' ); ... Zip support, requires jszip.
Read more >
Rise Thesis Template (ABNT) - CIn UFPE
of the requirements for the degree of Bachelor in Computer. Science. ... 3.1 A simple overview of the architecture up to the asynchronous...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found