Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

adding the type key "module" on the root will make threejs ESM-only

See original GitHub issue

Describe the bug

Hello! I was worried about this change of #23315 so I tested it and it validated my concern. By adding the type key on the root "type": "module" it will make threejs ESM-only and break all non-ESM libraries.

It should only be used in directories/user projects using ESM features such as test/package.json for example. Can we simply remove this line: "type": "module", or does the new paths ./ will break? @marcofugaro

Issue Analytics

State:
Created 2 years ago
Reactions:4
Comments:8 (5 by maintainers)

Top GitHub Comments

2reactions

Mugen87commented, Jan 25, 2022

I would say we give @marcofugaro’s solution a try and see how it works.

2reactions

marcofugarocommented, Jan 25, 2022

By adding the type key on the root “type”: “module” it will make threejs ESM-only and break all non-ESM libraries.

Not true, my attempt was to make three.js work both in esm and commonjs environment, according to the docs, I just forgot to provide a file with the .cjs extension.

Creating a new build output with the .cjs file fixes this.