Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

NodeMaterial : can't extend NodeMaterials classes

See original GitHub issue

Describe the bug

Extending any of the NodeMaterial based material classes creates a broken and unusable material since r138. It gives me this error : Uncaught TypeError: Cannot set properties of undefined (setting 'value').

Fix the bug

This problem occurs because the constructor.name is used to determine the value of type. This value will equal the name of the top-most class in the inheritance chain.

I believe setting it manually would be better (ex: PointsNodeMaterial.prototype.type = 'PointsNodeMaterial';). Or using a boolean (ex: PointsNodeMaterial.prototype.isPointsNodeMaterial = true;) (like many other things in threejs) !

Live example

codepen-latest-release (line 50 👀 )

Expected behavior

Extending any ThreeJs material class should work out of the box.

Platform:

Device: all
OS: all
Browser: all
Three.js version: r138

Issue Analytics

State:
Created 2 years ago
Comments:12 (6 by maintainers)

Top GitHub Comments

1reaction

sunagcommented, Oct 7, 2022

When I did the new WebGLNodeBuilder I must not have synced all the updates, this is one of the “big updates” problems. One of the safest methods of testing Three.js is the examples, and then the unit test that we are yet to implement for the nodes. The reason this has been repeated is the lack of an example that we can test after updates of “high impact” like new WebGLNodeBuilder, for that reason I added a simple example in this PR to avoid repeating this type of problem.

1reaction

sunagcommented, Mar 15, 2022

I posted a PR to fix it. I think it would be better not to use types other than what the class represents because that breaks serialization.