Obj.set should default to constructor defaults

Description of the problem

Consider this:

const a = new Vector3(4,5) // -> 4,5,0
a.set(1,2)
console.log(a) // -> 1,2,undefined

This is how the constructor is defined:

function Vector3(x, y, z) {
  this.x = x || 0;
  this.y = y || 0;
  this.z = z || 0;
}

And this is the set function:

function set(x, y, z) {
  this.x = x;
  this.y = y;
  this.z = z;
  return this;
}

It would be helpful and safer to assume constructor defaults always, for all objects that carry a set. Otherwise it’s throwing undefined into the renderer.

Here’s an example for instance that causes undefined behaviour where it works on some platforms but crashes on others: https://discourse.threejs.org/t/need-some-help-with-a-texture-that-doesnt-work-on-mobile/10553/2

[Mugen87]

No problem, this discussion is really hard to find^^.

@mrdoob To recap: The idea is to make the parameters of all .set() methods optional. If no arguments are provided, the current property value does not change (rather than assigning undefined or set a ctor default value). One could argue that we already do this in Euler.set() but we all know that Euler._order is somewhat special.

[drcmda]

well, not in typescript (i would assume). but either way, you can do this today as well. and it’s valid code (but sometimes kills the renderer due to undefined being treated as a number without checks).