Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

r133 getProgramInfoLog performance issue

See original GitHub issue

Description

When benchmarking r132 vs r133 on the same project, the first frame that initialise things with ProgramInfoLog is six times slower in r133.

To Reproduce

Steps to reproduce the behavior:

Use one of your existing three scene or project
Change the build from r132 to r133 r132 : https://raw.githubusercontent.com/mrdoob/three.js/r132/build/three.min.js r133 : https://raw.githubusercontent.com/mrdoob/three.js/r133/build/three.min.js

Code

<script src="https://raw.githubusercontent.com/mrdoob/three.js/r132/build/three.min.js"></script>
<!-- VS -->
<script src="https://raw.githubusercontent.com/mrdoob/three.js/r133/build/three.min.js"></script>

Screenshots

r125 : ( performance are stable ) up to r132 r125

r133 : six time slower ( average ) r133

Platform:

Device: [Desktop]
OS: [Windows]
Browser: [Chrome]
Three.js version: [r133]

Issue Analytics

State:
Created 2 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

2reactions

vanruesccommented, Oct 20, 2021

This could be related to #22631. getProgramInfoLog() might appear to take longer because texImage2D is blocking.

@swingingtom Do you use sRGBEncoding for the textures in your scene? Try using the WebGL1Renderer to check if loading times return to normal.

0reactions

swingingtomcommented, Oct 21, 2021

@vanruesc I confirm this is related to https://github.com/mrdoob/three.js/issues/22631

Changing texture.encoding = sRGBEncoding; for something else, or keeping sRGBEncoding and switching to WebGL1Renderer resolve the blocking time on r133.