Screenshots for CI on MacOS

Description of the problem

OS

• Windows
• macOS
• Linux

Right now all contributions in Three.js checked with regression tests. If you make a new PR you should also update screenshot in order to simplify code reviews. But current screenshot maker not works in MacOS, and somebody need to create screenshots on Windows or Linux for those users. This is not handy at all. If you have MacBook can you help me to fix CI script for MacOS?

Solution

Try to change flags to --use-gl=swiftshader in file below https://github.com/mrdoob/three.js/blob/47e1e3a9a0ac7cf6848ee005c172912ba4f6eff5/test/e2e/puppeteer.js#L60 or add some another, like --disable-setuid-sandbox and check what gives this command

npm run make-screenshot

right now it produces black images on MacOS.

[munrocket]

Wow, I am not thought that we can do it without GPU.

TEST PASSED! 356 screenshots correctly rendered.

Also we have all platforms inside CI and can check script with one button.

[mrdoob]

AFAIK, angle is GPU and swiftshader is CPU.

If we want to avoid GPU bugs, we may want to go with --user-gl=swiftshader everywhere…