Underscores removed from node names in GLTFLoader de-duplication process

Describe the bug

I see in (#16639) that duplicate node names are now appended with _i when using GLTFLoader. I have noticed in my application though that when i use an underscore _ in the node name string, the de-duplicated node process is removing them, which is breaking my application.

Live example The duplicated node name in the below jsfiddle is cool_box

Note that the 2nd and 3rd node names are then renamed cool box_1 & cool box_2 (first underscores removed) https://jsfiddle.net/vthyra4c/

Expected behavior

De-duplicated node names are appended with _i but the rest of the name string should remain intact.

Screenshots

Platform:

• Device: Deskto
• OS: Linux
• Browser: Chrome
• Three.js version: r123

PS. this is one of my first bug reports, let me know if i should have done something differently or included some other helpful info!

[ryans1224]

@mrdoob Yes, thanks to all

[ryans1224]

@donmccurdy Tried to track it down:

/** When Object3D instances are targeted by animation, they need unique names. */
	GLTFParser.prototype.createUniqueName = function ( originalName ) {

		var name = THREE.PropertyBinding.sanitizeNodeName( originalName || '' );

		for ( var i = 1; this.nodeNamesUsed[ name ]; ++ i ) {

			name = originalName + '_' + i;

		}

		this.nodeNamesUsed[ name ] = true;

		return name;

	};

In the for loop here, should name = originalName + '_' + i; be name = name + '_' + i … otherwise the sanitized node name is thrown out and not used, which correlates to what we are seeing