[Feature Request] Support Catkin Tools
See original GitHub issue- Windows: Windows 10 Enterprise Version 1909
- Linux: Ubuntu 20.04.1 LTS (WSL) (uname -a:
Linux *** 4.4.0-18362-Microsoft #1049-Microsoft Thu Aug 14 12:01:00 PST 2020 x86_64 x86_64 x86_64 GNU/Linux
) - ROS 1: Noetic
- ROS 2:
Version of the plugin: v0.6.4
Copy the Version information from the Help | About
menu:
Version: 1.49.1 (system setup)
Commit: 58bb7b2331731bf72587010e943852e13e6fd3cf
Date: 2020-09-16T23:27:51.792Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.18363
what is the bug
Under some circumstances, the ROS extensions selects the catkin_make build tools when catkin tools would be correct.
Repro steps
- Create ROS workspace
- Build with
catkin_make
- Remove
build
anddevel
directories - Build with
catkin build
- Load ROS workspace in VS Code
- Open build tasks (Ctrl+Shift+B) and see
catkin_make
andcatkin_make_isolated
as if the workspace was recently build withcatkin_make
(obviously,catkin_make
fails because the workspace was build withcatkin build
)
expected behavior
See catkin
as build task
additional context
Currently, the extension detects the build tool by looking if the file .catkin_workspace
(placed by catkin_make) or the directory .catkin_tools
(placed by catkin build) exist. Both tools also place a file at devel/.built_by
which contains the name of the build tool (catkin build
or catkin_make
).
(Bonus: Right now the names of the build tasks are very confusing. catkin_make: build
executes catkin_make
, catkin: make
executes catkin build
. The build task for catkin build
should be catkin: build
, catkin tools: build
or catkin tools: make
.)
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (3 by maintainers)
From the marketplace page
Has this been implemented, or is the marketplace text referring to something else?
Catkin tools is supported - https://github.com/ms-iot/vscode-ros/blob/master/src/build-tool/catkin-tools.ts. It looks like the check is currently not working.