Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Can I use SqliteCreateDatabaseIfNotExists within an external transaction?

See original GitHub issue

I want to use SqliteCreateDatabaseIfNotExists within a transaction, but I can’t because SqliteInitializerBase.InitializeDatabase() creates one while execution. Is there any way to use an external transaction with the initializer?

Issue Analytics

State:
Created 5 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

msallincommented, Jan 26, 2019

Thank you for your PR. As I look at this, I ask myself whether the first transaction is necessary. The first transaction is to ensure the atomicity of the Database creation. Inside this transaction the SqliteDatabaseCreator is called. There I wrote the following code: db.ExecuteSqlCommand(TransactionalBehavior.EnsureTransaction, sql); That this query will always be executed as transaction (either as a new one or the existing will be used). That means also, that your code will not work (there will always be a transaction, which is IMHO how it should be).

The solution here is simply to remove the first transaction creation in the initializer. -> The query will be executed always inside a transaction but you can specify your own.

Then there is the second part, the seeding of the data. There its also not necessary to have explicitly a transaction because SaveChanges is only called once, which means there is an implicit transaction.

Therefore, I’ll reject your PR and just delete the unnecessary code. It would be great if you can test your use case with it.

0reactions

msallincommented, Jan 28, 2019

Version 1.5.2 published. NuGet will list it within one hour.