emit close events
See original GitHub issuei notice you emit a limit
event, but IMO you should also emit a close
event both on that specific file stream as well as the busboy parser stream to signify the parser has stopped. i use the close
event to properly cleanup stuff.
http://nodejs.org/api/stream.html#stream_event_close
the close
event should be emitted after the limit
event.
Issue Analytics
- State:
- Created 10 years ago
- Reactions:1
- Comments:7 (2 by maintainers)
Top Results From Across the Web
Node.js Readable Stream close Event - GeeksforGeeks
The 'close' Event in a Readable Stream is emitted when the stream and any of its hidden resources are being closed This event...
Read more >HTMLDialogElement: close event - Web APIs | MDN
The close event is fired on an HTMLDialogElement object when the <dialog> it represents has been closed. This event is not cancelable and ......
Read more >Event 'close' emits twice (fs.createWriteStream) #31366 - GitHub
1 event emits once. Documentation: By default, the stream will not emit a 'close' event after it has been destroyed. This is the...
Read more >Stream | Node.js v19.3.0 Documentation
The 'close' event is emitted when the stream and any of its underlying resources (a file descriptor, for example) have been closed. The...
Read more >Component Events | Vue.js
All extra arguments passed to $emit() after the event name will be forwarded to the listener. For example, with $emit('foo', 1, 2, 3)...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
when there’s a limit event, the data is not “completely consumed” (the data being the underlying source, not busboy), so an
end
event is not appropriate. in other words,end
should only occur when the stream finishes successfully.This should be resolved in
busboy
v1.0.0 and with modern versions of node, which will emit'close'
natively on streams.