server fail to bind "forwardIn" port

Hi. Thanks mscdex for this module. I can’t understand why the code below work well when pointing to a real ssh server and fail when pointing to a node ssh2 mscdex server

I hope i’ve made a mistake and it’s a a bug or a limitation …

Requiring some serious help dude ! thanks in advance !

var ssh2 = require('ssh2');
var utils = ssh2.utils;
var fs = require('fs');
var keygen = require('ssh-keygen');
var ssh2Client = require('ssh2').Client;

// Pointing on mscdex ssh2 server
// run that
// then netstat -antp | grep 8000 -> KO
var clientDstKo = {
    ip:'127.0.0.1',
    port:23,
    username:'foo',
    password:'bar'
};

// Pointing on classical linux ssh daemon
// run that
// then netstat -antp | grep 8000 -> OK
// then telnet localhost port 8000 and everything is fine
var clientDstOk = {
    ip:'127.0.0.1',
    port:22,
    username:'realuser',
    password:'changeme'
};

// just change this to clientDstKo if you wanna reproduce the problem
var clientDst = clientDstOk;

var onClientConnected = function(client,info) {
    console.log('Server: client connected (%s)',info.ip);

    client
        .on('authentication', function(ctx) {
            if (ctx.method === 'password' && ctx.username === 'foo'&& ctx.password === 'bar') return ctx.accept();
            ctx.reject();
        })
        .on('ready', function() {
            client.on('request',function(accept,reject,name,info) {
                console.log('Server: request event fired:',name,info);
                accept();
            });
        });
};

var start = function(privateKey) {
    new ssh2.Server({
        privateKey: privateKey,
        //debug:console.log
    },onClientConnected)
        .listen(23, '127.0.0.1', function() {

            var client = new ssh2Client();

            client.on('tcp connection', function(details,accept,reject) {
                console.log('Client: tcp connection event fired, AS EXPECTED ! exiting ..',JSON.stringify(details));
                process.exit(0);
            });

            client.on('ready', function() {
                console.log('Client: ready event fired');

                this.forwardIn('localhost', 8000, function (err, portBinded) {
                    if (err) return console.log(err.message);
                    console.log('Client: server supposed to accept forwardIn port %s',portBinded);
                    console.log('Now you are supposed to see port 8000 listening on localhost, please telnet localhost 8000');
                    return true;
                });

            }).connect({
                host: clientDst.ip,
                port: clientDst.port,
                username:clientDst.username,
                password:clientDst.password,
                //debug:console.log
            });
        });
};

keygen({
    password: false,
    read: true,
    destroy:true
}, function(err, out){
    if(err) return cb(err);
    start(out.key);
});

[mscdex]

Here is a simple implementation that allows any ip/port:

var net = require('net');
// ...
.on('ready', function() {
  var proxied = {};
  client.on('request',function(accept,reject,name,info) {
    console.log('Server: request event fired:', name, info);

    if (name === 'cancel-tcpip-forward') {
      var server = proxied[info.bindAddr + ':' + info.bindPort]);
      if (server) {
        server.close();
        delete proxied[info.bindAddr + ':' + info.bindPort];
        accept();
      } else
        reject();
    } else if (name === 'tcpip-forward') {
      var proxy = net.createServer(function(sock) {
        client.forwardOut(info.bindAddr,
                          info.bindPort,
                          sock.remoteAddress,
                          sock.remotePort,
                          function(err, clientStream) {
          if (err)
            return sock.end();
          clientStream.pipe(sock).pipe(clientStream);
        });
      }).on('error', function(err) {
        // Most likely could not bind to the address/port
        reject();
      }).listen(info.bindPort, info.bindAddr, function() {
        proxied[info.bindAddr + ':' + info.bindPort] = proxy;
        accept();
      });
    } else
      reject(); // Unsupported request
  }).on('end', function() {
    // Clean up any forwarded ports that were left open
    Object.keys(proxied).forEach(function(key) {
      proxied[key].close();
    });
    proxied = null;
  });
});

[franck34]

wow … i have to study now !

thank you so much again. I saw many things in closed ticket speaking about what i wan’t to do.