Can't install the service worker in Electron renderers with `nodeIntegration` enabled

Describe the bug

Invoking worker.start() in an Electron renderer fails if nodeIntegration is enabled. This happens because process is defined, which causes isNodeProcess to return true. As a result, it’s not possible to use msw in these windows. (msw’s node server doesn’t work in that environment either, since fetch calls use the Chromium network stack, not Node’s.)

Electron provides process.type with value "renderer" in these situations. Would it be satisfactory for isNodeProcess to return false in that case? If so, I’m happy to put up a PR!

Environment

• msw: 0.27.1
• nodejs: 12.18.3
• npm: 7.6.3

Please also provide your browser version.

Electron 11.3.0 / Chromium 87

To Reproduce

Steps to reproduce the behavior:

1. Create Electron BrowserWindow with nodeIntegration: true
2. Create an msw service worker and invoke worker.start()
3. Open DevTools, view Console
4. See error:

[MSW] Failed to execute `setupWorker` in a non-browser environment. Consider using `setupServer` for Node.js environment instead.

Expected behavior

Service worker is installed

[Akallabet]

@kettanaito it looks like the new lib is-node-process, which msw relies upon, doesn’t have this change

if (process?.type === 'renderer') {
  return true
}

If I understood correctly, this was the accepted fix?

[Pagebakers]

I think there has been a regression. I’m not able to run msw in Electron anymore.

Unhandled Runtime Error
Error: [MSW] Failed to execute `setupWorker` in a non-browser environment. Consider using `setupServer` for Node.js environment instead.