`credentials` config not supported in node?

Describe the bug

When I set the credentials config in fetch to 'omit' that isn’t passed along to the req.

Environment

• msw: 0.0.18
• nodejs: 12
• npm: 6.14.5

To Reproduce

https://github.com/kentcdodds/bookshelf/commit/b733434fbfbef5d8d67aca15a444c9b063437615#diff-47664a78a0147eab6cc64883365d1ef4R75-R76

test('allows for config overrides', async () => {
  let request
  const endpoint = 'test-endpoint'
  const mockResult = {mockValue: 'VALUE'}
  server.use(
    rest.get(`${apiURL}/${endpoint}`, async (req, res, ctx) => {
      request = req
      return res(ctx.json(mockResult))
    }),
  )

  const customConfig = {
    credentials: 'omit',
    headers: {'Content-Type': 'fake-type'},
  }

  await client(endpoint, customConfig)

  // TODO: this should pass but it's not...
  // expect(request.credentials).toBe(customConfig.credentials)
  expect(request.headers.get('Content-Type')).toBe(
    customConfig.headers['Content-Type'],
  )
})

Expected behavior

I expect the request.credentials to bet set to what is set in the window.fetch call.

[kentcdodds]

Interesting! In any case, it seems that this is out of scope for this module and it’s actually up to the polyfill to deal with this.

Also, it’s not critically important to me anyway so I’ll go ahead and just close this.

Thanks for the discussion everyone 😃

[kimroen]

What they are doing that might be debated though, is assuming same-origin (the default) means “don’t include the credentials ever”, but that has already been discussed fairly extensively over here: https://github.com/whatwg/fetch/pull/585