req doesn't seem to be correctly set when using node

Describe the bug

the first parameters in rest methods does not seem to be correctly set, at least req.url, req.query ( undefined) and req.params: empty object

Environment

• msw: 0.19.0
• nodejs: 12.16.1
• npm: 6.13.4

To Reproduce

Here’s a test to reproduce. I’d expect query to be defined but the value is undefined, there’s no way for me to have the value of email in my handler.

import fetch from 'isomorphic-fetch';
import { rest } from 'msw';
import { setupServer } from 'msw/node';

const server = setupServer(
  rest.get('/foo', (req, res, ctx) => {
    console.log(req);
    return res(ctx.text(''));
  }),
);

describe('', () => {
  beforeEach(() => {

    server.listen();
  });
  afterAll(() => {
    server.close();
  });
  it('should work', async () => {
    const res = await fetch('http://localhost/foo?email=ok');
    expect(await res.text()).toBe('');
  });
});

The result of my console.log is

    {
      url: URL {},
      method: 'GET',
      body: '',
      headers: Headers {
        map: {
          'accept-encoding': 'gzip,deflate',
          'user-agent': 'node-fetch/1.0 (+https://github.com/bitinn/node-fetch)',
          connection: 'close',
          accept: '*/*'
        }
      },
      params: {},
      redirect: 'manual',
      referrer: '',
      keepalive: false,
      cache: 'default',
      mode: 'cors',
      referrerPolicy: 'no-referrer',
      integrity: '',
      destination: 'document',
      bodyUsed: false,
      credentials: 'same-origin'
    }

url seems suspect: empty, query is not defined and params is empty.

Expected behavior

i’d expect req.url to have the full path of the request, req.query to be an URLSearchParams. Not sure what should be req.params

I’d be willing to help to fix this, if this a bug / missing feature. Thanks for your help!

[Axnyff]

This indeed works! my bad I almost got fooled again as req.url.searchParams also prints something that looks empty, really weird… Thanks for your help anyway!

This page probably needs to be updated: https://redd.gitbook.io/msw/recipes/query-parameters I can look into this if the docs are hosted on github

[kettanaito]

Hey, @Axnyff. Thanks for reporting this!

Please, can you try req.url.searchParams.get('email')?

The query parameters references via req.query were deprecated, as it effectively duplicates what you can access in req.url.searchParams using a much more comfortable URLSearchParams interface.

Note that req.url is a URL instance, that is not serialized when printed into stdout. That’s why you see {}, which may falsely look like an empty object.