REST query is mistaken for GraphQL query and can't be intercepted (throws an error)

Environment

Name	Version
msw	0.28.2
browser	Chrome
OS	Mac OS X Catalina

Request handlers

no request handler for the following rest request

https://api.dev/artists?query=Petit+Biscuit&page=0&limit=5&workspaceId=ce54f030-2191-40b1-8b2a-cd5167e9ec5f

Actual request

const results = await Axios.get('/artists', {
    params: {
      query,
      page,
      limit,
      workspaceId,
      onlyBelieveArtists,
    },
  });

Current behavior

Browser console throws an error :

[MSW] Failed to intercept a GraphQL request to “GET https://api.dev/artists”: cannot parse query. See the error message from the parser below.

Expected behavior

no error shoud be thrown as it is not a GraphQL request

this happens in

parseGraphQLRequest method

seemingly because it relies on the presence of a query param to start and parse the query

should this method even be called? maybe it should as no rest handler is provided it also tries to find a graphQL handler

thanks for any input on this

[thomasmery]

thanks,

makes sense if I turn the logging into a throwing

I’ll try and open a PR by the end of the week 😃

[kettanaito]

We can try to

1. Throw an exception instead of logging an error.
2. Wrap the parseGraphQLRequest call in the onUnhandledRequest function in something like maybe or tryCatch custom function that would silence any exceptions thrown.

Thank you for your support!