TypeError: expected.toLowerCase() is not a function when using "rest.all()"

Describe the bug

When using rest.all() to mock all requests of a given path, it blocks HMR (and other requests).

That’s due to an issue with the usage of isStringEqual in the file src/utils/request/onUnhandledRequest.ts. It assumes that method is always a string and with the introduction of rest.all it seems to be a RegExp now.

Environment

• msw: 0.36.0
• nodejs: 14.17.6
• npm: 6.14.15
• yarn: 1.22.15
• Chrome: Version 96.0.4664.55 (Official Build) (x86_64)

To Reproduce

Steps to reproduce the behavior:

1. Scaffold a create-react-app
2. Set up MSW with a rest.all() handler (mine was like this: rest.all('/todos', (req, res, ctx) => {...});
3. Run yarn start
4. Make a change on one of the files
5. See error in the console like the ones below:

Expected behavior

Requests not targeted by the rest.all() should still be performed. By temporarily patching the rest-deps changing the return to:

return actual.toString().toLowerCase() === expected.toString().toLowerCase();

solved the issue, but I know that’s not the right fix 😄

Screenshots

HMR broken:

(also messes requests for the chrome extension)

[kettanaito]

The fix has been released in 0.36.2.

[rmachado-studocu]

Hi @kettanaito,

From what I can see, you’re creating all as RegExp handler: https://github.com/mswjs/msw/blob/master/src/rest.ts#L35

I was checking on the integration tests and it hasn’t been caught on them because you always have a fallback - rest.all('*', () => { ... }); - and you check against that generic response.

The issue here is exactly the case where you set up something like:

rest.all('/specific/endpoint', () => { /*...*/ });

And a request is done to say /another/different/endpoint… Not having any generic request should let it pass and request the actual resource… right?