msys2 shell error handling issues

See the following workflow: https://github.com/lazka/msys2-workflow-error-test/actions/runs/167621530/workflow

The ubuntu bash runs by default with set -e (It’s documented as set -e o pipefail here https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference but it doesn’t look like that’s true)

The msys2 shell doesn’t which means a failing command doesn’t fail the step, which is imo bad, at least for a default behavior in CI. It should at least default to -e

Any ideas?

[lazka]

yes!

[lazka]

This was already reported here actions/runner#353

I think that’s a similar but unrelated issue. It is about getting a different behaviour when not setting shell or when setting it to bash. In our case, we don’t use any of them, neither the default nor bash. Our entrypoint is msys2.cmd.

Yeah, unrelated, I just wanted to suggest at first that we should mirror what bash does in GHA ideally, but turned out that it wasn’t that clear…