question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[AppBar] Safari does not shift when persistent Drawer is re-opened

See original GitHub issue

While working on mui-app-container, I ran into an issue with AppBar that appears to only be present on Safari (it does not exhibit on Chrome or IE 11 at least) - when toggling a persistent drawer closed and then reopen it, the AppBar does not account for the width of the drawer.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

An AppBar should offset to the right by the amount of the drawer after reopening.

Current Behavior

After closing and reopening a persistent Drawer, the left side of AppBar is now under the Drawer instead of being shifted to the right. This is present on the v1 docs as of today (v1.0.0-beta.28). Notice the “Drawers” title not being present.

Safari (problem)

safari_20180116

Chrome (no problem)

chrome_20180116

You can also see this problem when toggling the persistent drawer example (notice “Persistent drawer” no longer being visible when the drawer is open) safari2_20180116

You can also see this problem reproduced in mui-app-container’s storybook with the story source here

Steps to Reproduce (for bugs)

  1. Go to persistent drawer example
  2. Click on menu icon to toggle drawer
  3. Notice “Persistent drawer” title is hidden under drawer instead of being shifted]

Context

I have been working on creating a <AppContainer> component to help orchestrate <Drawer>, <AppBar>, and content components and came across this issue.

Your Environment

Tech Version
Material-UI v1.0.0-beta.28
React 16.1.1
browser Safari 11.0.2 (desktop and iOS)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:9 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
oliviertassinaricommented, Jan 16, 2018

@techniq Thanks for digging into it! The WebKit bug report looks very close to the issue we are experiencing.

0reactions
techniqcommented, Jan 18, 2018

@oliviertassinari OK. I might implement a workaround in my mui-app-container to remove the transition prop if on Safari <11.1 as this seems to be the best workaround I’ve found (now will just need a way to detect Safari <11.1 especially since they are going to stop updating their user-agent last I heard).

Read more comments on GitHub >

github_iconTop Results From Across the Web

[AppBar] Safari does not shift when persistent Drawer is re ...
After closing and reopening a persistent Drawer , the left side of AppBar is now under the Drawer instead of being shifted to...
Read more >
Material UI persistent drawer - content body not resizing
In general the drawer itself works fine, but the loaded components are not resizing, when the drawer opens or closes.
Read more >
Change Desktop & Dock settings on Mac - Apple Support
To change these settings, choose Apple menu > System Settings, then click Desktop & Dock in the sidebar. (You may need to scroll...
Read more >
Changelog | Docs - TinyMCE
Crop functionality did not work in the imagetools plugin when the editor was ... The context toolbar will now move out of the...
Read more >
How to Clear Cache for All Major Browsers - Kinsta
Even though she may not know it, browser caching helps Marla in the ... Apple Safari: SHIFT + Reload toolbar button; Chrome and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found