[ButtonBase] Incorrectly adds role='button' when using a custom component and passing an href prop

When using a material-ui button it adds role='button' when using a custom component prop even when passing an href prop.

I believe that this line in ButtonBase.js is the culprit. Perhaps it should be an && instead of ||

• The issue is present in the latest release.
• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Material-Ui ButtonBase.js applies role='button' attribute to the button when using a custom component even when passing an href prop

Expected Behavior 🤔

when using a custom component and passing an href prop to a button it should not have role='button' applied

Steps to Reproduce 🕹

See repro here: https://codesandbox.io/s/green-sun-vduiu?file=/src/Demo.tsx

Steps:

1. inspect button and see it has role='button' on it

Context 🔦

Trying to create proper accessibility for links that look like buttons in a Gatsby.js site.

[mnajdova]

Let’s discuss this in a PR with a concrete implementation and test. Manually going through implementation is not viable.

Sounds good. @Gautam-Arora24 you may start working on this if you want 😃

[eps1lon]

Let’s discuss this in a PR with a concrete implementation and test. Manually going through implementation is not viable.