Can we put ListItemText and table body cell text in a font size category of their own or use body2/body1?
See original GitHub issue- This is a v1.x issue.
- I have searched the issues of this repository and believe that this is not a duplicate.
Shouldn’t <Typography variant="subheading">
only be used for places in the app that are conceptually a subheading (i.e. smaller text under the title of a section)? I think ListItemText
is abusing it. The primary text of a list item has nothing to do conceptually with a subheading in my mind and I want to be able to control the default list item text and subheading text size independently.
Not to mention that ListItemText
uses <Typography variant="body1">
for its secondary text. (What is the concept behind body1
either?)
Personally I think list item primary text is in a conceptual category of its own, a category in which the default text size in table body cells should belong as well. If anything the size should probably just be the same as the body text (consider the fact that you guys are using body2
/body1
in the list items of the sidebar of your own docs, or something that looks very similar to it? 😉)
I’m finding it pretty awkward to stick to a few conceptually clear categories of text size while satisfying the requirements from the UX team.
Issue Analytics
- State:
- Created 5 years ago
- Comments:19 (19 by maintainers)
Top GitHub Comments
Many components have some prop like
someComponent
so this is still possible for (hopefully) most use cases.On Sat, Sep 1, 2018, 18:24 Andy Edwards notifications@github.com wrote:
The discussion continues in #13900.