question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Can we put ListItemText and table body cell text in a font size category of their own or use body2/body1?

See original GitHub issue
  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Shouldn’t <Typography variant="subheading"> only be used for places in the app that are conceptually a subheading (i.e. smaller text under the title of a section)? I think ListItemText is abusing it. The primary text of a list item has nothing to do conceptually with a subheading in my mind and I want to be able to control the default list item text and subheading text size independently.

Not to mention that ListItemText uses <Typography variant="body1"> for its secondary text. (What is the concept behind body1 either?)

Personally I think list item primary text is in a conceptual category of its own, a category in which the default text size in table body cells should belong as well. If anything the size should probably just be the same as the body text (consider the fact that you guys are using body2/body1 in the list items of the sidebar of your own docs, or something that looks very similar to it? 😉)

I’m finding it pretty awkward to stick to a few conceptually clear categories of text size while satisfying the requirements from the UX team.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:19 (19 by maintainers)

github_iconTop GitHub Comments

1reaction
eps1loncommented, Sep 1, 2018

Many components have some prop like someComponent so this is still possible for (hopefully) most use cases.

On Sat, Sep 1, 2018, 18:24 Andy Edwards notifications@github.com wrote:

@eps1lon https://github.com/eps1lon oh, thanks for putting that example together, I didn’t realize that I can pass props with the theme. That should do it for me. I do still wish I could override entire components though…because I always want more ability to control the tools I use 😃

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mui-org/material-ui/issues/12726#issuecomment-417870471, or mute the thread https://github.com/notifications/unsubscribe-auth/ALuPz1loSGM90W3Wp7N-q255oRXmE3cNks5uWrSfgaJpZM4WUP7M .

0reactions
oliviertassinaricommented, Dec 14, 2018

The discussion continues in #13900.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Can we put ListItemText and table body cell text in a font ...
Personally I think list item primary text is in a conceptual category of its own, a category in which the default text size...
Read more >
MUI - Styling text inside ListItemText
I beleive the only way to achieve this right now is to use the 'disableTypography' prop of the ListItemText element.
Read more >
ListItemText API - Material UI
API reference docs for the React ListItemText component. ... You can learn about the difference by reading this guide on minimizing bundle size....
Read more >
How to specify font styles for text inside tables, the easy way
Let's look at the following sample table. Note how the FONT tags are being used to set the font style of text inside...
Read more >
material-ui/core/CHANGELOG.md
We will make the documentation of the v5 alpha releases available under ... 280, - [docs] Use rem in responsive font sizes chart...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found