core 1.5.1 breaks icons 1.*
See original GitHub issueBuilding breaks for users of @material-ui/icons 1.1.0 with error
Error: Cannot find module '@babel/runtime/helpers/builtin/interopRequireDefault' from '.../node_modules/@material-ui/icons'
@material-ui/icons 1.1.0 declares that it works with any core of v1
"peerDependencies": {
"@material-ui/core": "^1.0.0-rc.0",
but that’s not true for 1.5.1. 1.5.1 depends on @babel/runtime 7.0.0-rc.1 as opposed to 7.0.0-beta.42 in 1.5.0. 7.0.0-rc.1 changes the location of interopRequireDefault.
- This is a v1.x issue.
- I have searched the issues of this repository and believe that is a duplicate of https://github.com/mui-org/material-ui/issues/12587, but it’s closed.
Expected Behavior
icons v1 can be used
Current Behavior
Error: Cannot find module '@babel/runtime/helpers/builtin/interopRequireDefault' from '.../node_modules/@material-ui/icons'
Steps to Reproduce
https://codesandbox.io/s/oow4nvrm36
Proposal
Release icons 1.1.1 that would work with core 1.5.1 and babel core 7.0.0-rc.1
Issue Analytics
- State:
- Created 5 years ago
- Reactions:3
- Comments:15 (10 by maintainers)
Top Results From Across the Web
core 1.5.1 breaks icons 1.* · Issue #12621 · mui/material-ui
Building breaks for users of @material-ui/icons 1.1.0 with error ... Release icons 1.1.1 that would work with core 1.5.1 and babel core ......
Read more >Module not found: Can't resolve '@material-ui/core/AppBar'
This resolved the broken dependencies between materialui and react. ... @material-ui/core. This method is the same for @material-ui/icons.
Read more >@material-ui/icons | Yarn - Package Manager
@material-ui/icons. This package provides the Google Material icons packaged as a set of React components. Installation. Install the package in your project ...
Read more >Argento changelog - SwissUpLabs docs
6 and Magento 2.4.1. Fixed system.log WARNING about broken reference at different themes. Occurs when catgory page or product page layout is changed...
Read more >No Icon Themes loading after update on XFCE
but this broke the icon settings, now I can't open 'settings ... 13574 Speed: 798 MHz min/max: 800/1700 MHz Core speeds (MHz): 1:...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I’m concerned about this.
As
@material-ui/icons@2.0
is a breaking change over 1.1, the fact that@material-ui/core@1.5.1
requires us to upgrade@material-ui/icons
to 2.0 IS a breaking change for the core. So core 1.5.1 should have been a 2.0 in that regard.Alternatively, please revert the babel upgrade in 1.5.1, or backport the material-ui/icons fix to the 1.x branch.
@fzaninotto Fair point. I guess we can make a patch release for
@material-ui/icons@1.x
.