[design-system] Support error|success|warning|info by default in color prop
See original GitHub issue- The issue is present in the latest release.
- I have searched the issues of this repository and believe that this is not a duplicate.
Current Behavior 😯
It already supported out of box in V5.
https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/Button/Button.js#L137 https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/Button/Button.js#L116 https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/Button/Button.js#L116
User could add it to theme via interface merge, but it would be nice to add it in core
declare module '@material-ui/core/Button' {
interface ButtonPropsColorOverrides {
error: true;
info: true;
success: true;
warning: true;
}
}
Issue Analytics
- State:
- Created 3 years ago
- Reactions:4
- Comments:25 (25 by maintainers)
Top Results From Across the Web
success|warning|info by default in color prop · Issue #24778 ...
I was under the impression we already support in @material-ui/core@5.0.0-alpha.24 . If it's not working , can you share a reproducible example?
Read more >Color in UI - Carbon Design System
Carbon's default themes are derived from the IBM Design Language color palette. The neutral gray family is dominant in the default themes, making...
Read more >Defining Colors in your Design System - UX Collective
Semantic Colors. These are the colors that communicate purpose. They help users convey messages. For example, Green has a positive connotation.
Read more >Design Tokens - Lightning Design System
Design tokens are the visual design atoms of the design system ... Token Support Legend: ... Generic colors to use within a Salesforce...
Read more >Color | Interface guidelines - Primer Design System
Design tokens are a layer of abstraction that allows better maintainability, consistency and easy theming. For example use bg-default for the background of...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
It seems that we have a working POC in https://github.com/mui-org/material-ui/issues/24778#issuecomment-774627820 and we have a product direction agreement. I’m changing the label 😃
@oliviertassinari @mnajdova What do you think about,
For 1 and 2, we can start separately now since (1) is bug fix and (2) is enhancement. For 3, wait for someone to pick up or we can work on this in v5 beta? (is it a breaking change?)