Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FR: Granular control over date/time pickers.

See original GitHub issue

It would nice to have the below features in the picker:

Allow Custom header messages (useful when there are multiple pickers with autoOK)
Make action buttons optional, again useful with multiple pickers.
All custom defined, onTouchTap events for action buttons.

Let me if this sounds ok, ready to do a PR.

Issue Analytics

State:
Created 8 years ago
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

mbrookescommented, Apr 5, 2016

@hemanth Closing this for now. The custom header wouldn’t work with a landscape dialog, the button labels can be customised, and hooks for the buttons isn’t something we want to add.

0reactions

alitahericommented, Dec 10, 2015

@hemanth The edge cases are so many. and this use-case is so specific. If we make actions customizabe then how far should be expose them? we’ll end up with date-picker having a huge number of prop. if we provide an actions prop so the user can provide the buttons then how will we hook the OK and CANCEL with them? this will lead to a very un-intuitive API. Maybe it’s best to provide ways for users of this library to build their own date-picker the way they want. By exposing all date-picker components and customization guild. @oliviertassinari What do you think?