question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Grid] IE 11 support

See original GitHub issue

If you include the Grid component, an error occurs in URL search of Google search console. This problem does not occur at least on Chrome and Edge. As there is no complaint from the user, it will not occur in Safari, too.

Problems began to occur in May. Until then, screenshots were displayed in the Google Search Console. I think that the change of Google Crawler is affecting. Even my code needed to be corrected in two places.

As I am not good at English, I write with the help of translation.

  • This is not a v0.x issue.
  • [x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

A screen shot will be displayed.

Current Behavior 😯

Screen shots are not displayed. Console error message: TypeError: undefined is not a function

Steps to Reproduce 🕹

Link:

  1. Create a component that contains a Grid component. (ex. return (<Grid></Grid>);)
  2. npm run build
  3. Deploy in an environment accessible by Google Search Console.
  4. Run a live test of URL inspection from Google Search Console.

Context 🔦

I’m expecting the crawler to understand the page correctly.

Your Environment 🌎

Tech Version
Material-UI v4.0.0
React v16.8.6
Browser Google Search Console
TypeScript
react-router-dom v5.0.0
react-scripts v3.0.1

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
qrusadorzcommented, Jun 3, 2019

I confirmed that it was improved in v 4.0.2. I used Google’s Mobile-Friendly Test Site. Thank you very much.

1reaction
oliviertassinaricommented, May 27, 2019

@qrusadorz Thank you for trying it out. The problem is in this line: https://github.com/mui-org/material-ui/blob/8cfaa9880ad59b8c11121ce507dacad54aba13ce/packages/material-ui/src/Grid/Grid.js#L61

It was transpiled in beta.1 but it’s not longer in beta.2 (and in v4.0.1).

I think that we should add Object.assign back as it’s not supported by IE 11 or rewrite the source to move away from Object.assign. No matter what, we have an issue with the end-to-end tests. The problem wasn’t detected. What do you think @eps1lon?

Read more comments on GitHub >

github_iconTop Results From Across the Web

CSS Grid in IE11: It's Possible! And Not as Hard as You Think
grid -auto-rows and grid-auto-columns are not supported, because IE11 can only create columns and rows automatically based on the size of the ...
Read more >
Supporting CSS Grid in Internet Explorer | by Elad Shechter
In this post I will teach you how to support CSS Grid in IE 10 and above, while using the old CSS Grid...
Read more >
CSS Grid in IE: Debunking Common IE Grid Misconceptions
Duplicate area names now supported! To start off, this first part is going to debunk some common misconceptions around IE11's native grid ......
Read more >
CSS Grid Layout (level 1) | Can I use... Support ... - CanIUse
Method of using a grid concept to lay out content, providing a mechanism for authors to divide available space for layout into columns...
Read more >
CSS Grid Layout not working in IE11 even with prefixes
According to CanIUse IE and Edge use an older version of the Grid spec. · CanIUse also specifies that it is partially supported...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found