Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Grid] Replace px to rem in spacing prop

See original GitHub issue

Now

<Grid spacing={8/padding: 4px|16/padding: 8px|32/padding: 16px|40/padding: 32px}>

Need

<Grid spacing={8/padding:0.25rem|16/padding:0.5rem|32/padding:0.75rem|40/padding:1rem}>

or add another prop spacingRem

Issue Analytics

State:
Created 5 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

oliviertassinaricommented, Jul 31, 2019

@Und3Rdo9 It looks like that I have changed my mind a bit since last year 😃

1reaction

oliviertassinaricommented, Jul 29, 2019

@Und3Rdo9 Oh, that’s a bug! We could imagine the following change:

diff --git a/packages/material-ui/src/Grid/Grid.js b/packages/material-ui/src/Grid/Grid.js
index 9fa4d375f..c59765def 100644
--- a/packages/material-ui/src/Grid/Grid.js
+++ b/packages/material-ui/src/Grid/Grid.js
@@ -74,11 +74,16 @@ function generateGutter(theme, breakpoint) {
       return;
     }

+    const half =
+      typeof themeSpacing === 'number'
+        ? themeSpacing / 2
+        : themeSpacing.replace(/(\d+\.\d+)/, (str, p1) => p1 / 2);
+
     styles[`spacing-${breakpoint}-${spacing}`] = {
-      margin: -themeSpacing / 2,
+      margin: -half,
       width: `calc(100% + ${themeSpacing}px)`,
       '& > $item': {
-        padding: themeSpacing / 2,
+        padding: half,
       },
     };
   });