question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking changes from 3.2.2 to 3.2.3

See original GitHub issue

Breaking change

Environment

Tech Version
@material-ui/pickers 3.2.3
material-ui ^4.3.2
React ^16.8.6
Browser Chrome
Peer library @date-io/date-fns”: “^1.3.9”, “date-fns”: “^2.0.0-beta.5”,

Steps to reproduce

  1. This is not an obvious one - when a name of a third party component changes that causes our tests to break because testcafe needs string for their react selector. On a similar note I have seen failing tests when people are using snapshots for their jest tests -> these will also fail whenever the name change. i.e. the name changed from WrappedPurePicker to PickerWithState

  2. I am using React + Typescript and when I updated from 3.2.2 to 3.2.3 my typescript compiler started complaining that label is not defined and started kicking about name when I deleted label etc.

Expected behavior

  • When I downgrade to 3.2.2 everything works as expected and I dont need to change the props I am passing to the DatePicker component

Actual behavior

Typescript error

Live example

Code: We are using Formik for the forms so our component looks like this:

              <DateTimePicker
                data-tc="hello"
                key="hello"
                label="Hello"
                name="hello"
                showTodayButton
                allowKeyboardControl
                disablePast
                ampm={false}
                format="dd/MM/yyyy HH:mm"
                value={values.hello}
                onChange={value => setFieldValue('hello', value)}
                onClose={() => setFieldTouched('hello', true)}
              />

And when I have updated to version 3.2.3 it started throwing typescript errors:

  Property 'label' does not exist on type 'IntrinsicAttributes & DateValidationProps & BasePickerProps & { variant?: "inline" | "static" | "dialog" | undefined; } & Pick<ModalWrapperProps<{}>, "okLabel" | "cancelLabel" | ... 4 more ... | "DialogProps"> & Pick<...> & Pick<...> & DateTimePickerViewsProps & { ...; }'

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

2reactions
sdirixcommented, Aug 26, 2019

See this codesandbox to reproduce the issue. Note that it takes some time in codesandbox for the error to show up. label is correctly applied to the text input, however it is not accepted by the typings.

1reaction
Flash619commented, Aug 26, 2019

I’m experiencing the same issue on 3.2.4. Dropping back to 3.2.2 fixed it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

berry/CHANGELOG.md at master · yarnpkg/berry - GitHub
The shell now treats backslashes same as Bash (so it mostly ignore them). Could potentially be a breaking change, but the old behavior...
Read more >
Is it safe to upgrade to the later minor or patch version of ...
Upgrading to the later minor or patch version of Spartacus should not introduce any breaking changes to your application.
Read more >
What's New In Python 3.2 — Python 3.11.1 documentation
Author, Raymond Hettinger,. This article explains the new features in Python 3.2 as compared to 3.1. Python 3.2 was released on February 20, ......
Read more >
Collections – Release notes for version 3.2.2
Release notes for version 3.2.2. Commons collections is a project to develop and maintain collection classes based on and inspired by the ...
Read more >
Migrating from v2 to v3 - Gatsby
Handling Breaking Changes · Minimal Node.js version 12.13.0 · webpack upgraded from version 4 to version 5 · ESLint upgraded from version 6...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found