question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal: rename button variants to follow the spec

See original GitHub issue

Material Guidelines changed the name of buttons’ variants. I’m proposing to update the variants name to follow the spec and implement those that are missing.

The rosetta stone is:

Material UI Beta 45 Current API Material Guidelines Proposed API
Flat Button variant="flat" Text Button variant="text"
N/A N/A Outlined Button variant="outlined
Raised Button variant="raised" Contained Button variant="contained"
N/A N/A Toggle Button toggled variant="outlined"

I’m not proposing a specific variant for Toggle Buttons because demos present them as button bars (hence could be a good idea have a specific component) where they are mostly outlined buttons with an additional toggled state, or Icon Buttons with different icons based on the state.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

4reactions
mbrookescommented, Jun 26, 2018

I suggest we stick with the spec names, rather than what the MCW team are using.

0reactions
eps1loncommented, Oct 7, 2018

Legacy variant names will be deprecated with 3.2.0 i.e. deprecation warnings will be logged. The flat and raised variants were already mapped to text and contained respectively.

Read more comments on GitHub >

github_iconTop Results From Across the Web

rename button variants to follow the spec · Issue #11284 · mui ...
Material Guidelines changed the name of buttons' variants. I'm proposing to update the variants name to follow the spec and implement those that ......
Read more >
When you should use variants VS creating separate ...
Before variants, the only way we could organize Figma components was using forward slashes or frames to group and nest them together.
Read more >
Prepare for variants - Figma Help Center
You'll be able to change the name and order of any properties once you convert them to variants. Reorder properties in the Variants...
Read more >
Human Interface Guidelines - Design - Apple Developer
By default, all variants of the button title capitalize the first word — that is, Sign or Continue — and Apple; all other...
Read more >
Spec: V2 Ecommerce Events | Segment Documentation
Browsing lifecycle events represent key events that a customer might have while browsing your apps. Products Searched. Fire this event when a ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found