Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

skipSx should update shouldForwardProps

See original GitHub issue

Duplicates

I have searched the existing issues

Latest version

I have tested the latest version

Summary 💡

The skipSx doesn’t work as expected when shouldForwardProp default mechanism is overwritten and does not include 'sx' directly

shouldForwardProp: (prop) => !["isEven"].includes(prop as string),
skipSx: true

This will send sx to the underlying component

Examples 🌈

I made a code sandbox using the latest released material

https://codesandbox.io/s/goofy-phoebe-xc99x

Motivation 🔦

making a custom component that only changes in CSS layer duo to props is a common practice also, sx seems to be a little bit slow, and skipping it may gain some performance tips

so because we are working mostly with the Mui component and they pass the props to the underling dom node, it makes sense to have it as a core feature of the material

I seared on skipSx tags in the issue list and could not find an open issue, so posted a new one.

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

michaldudakcommented, Mar 3, 2022

It would be a breaking change, though, so we could think about it for the v6 release.

1reaction

mnajdovacommented, Mar 2, 2022

After reading trough it I think it makes sense for the skipSx prop to determine whether to forward the sx prop or not. I think we should combine this logic with the default shouldForwardProp. But, if a custom shouldForwardProp function is specified, it should be a responsibility of the developer to decide on it. I am not sure if this is very intuitive.