Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Tabs] Default 'width' to 'auto' instead of '100 / n%'

See original GitHub issue

I propose considering that Tab components are not equal width by default. If you are putting content in the Tab elements of variable width, the tabs do not render gracefully:

In the situation below, my Tabs are in side an AppBar component.

Tabs with ‘width’ set to ‘100 / n%’ (in this case, 20%):

Tabs with ‘width’ set to ‘auto’:

I’d be happy to open a PR if consensus is in favor of the change.

Issue Analytics

State:
Created 7 years ago
Comments:8 (7 by maintainers)

Top GitHub Comments

7reactions

alitahericommented, Mar 30, 2016

Yeah I’m working on a method to calculate the position the inkbar should be in using getBoundingRect. this way, the inkbar will be positioned correctly depending on hot each Tab is rendered, not on how it assumes it will be rendered.

2reactions

mbrookescommented, Mar 27, 2016

@alitaheri is still working on a fork of #2861. Might be worth waiting until he’s back from vacation to see whether this is already covered.

In any case, I understand what you’re saying about auto by default being a non-breaking change, as min-width (I’m assuming) will make the tabs evenly spaced by default.