question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Tabs] Improve color management

See original GitHub issue

Tabs by default receive the MuiTab-textColorInherit class, which for some reason sets their opacity to .7. Honestly I don’t know what I’m missing, it’s not in the docs but nobody on the internet seems to have complained about this. I can’t imagine why this was included except to discourage developers from using inherit, in which case shouldn’t it just be removed, or at least an opt-in behavior instead of a default? It’s been in the code for 3 years but I can’t wrap my mind around the decision here. At risk of stating the obvious, I expected that Tabs using inherited colors would be colored with the colors they inherited, and not mixed with 30% of the colors behind them. I’m forced to add an opacity rule to my theme for tabs if I want the obvious behavior, and figure out on my own why the colors are wrong given that it doesn’t appear to be documented.

What you need to put in your theme overrides to fix this in case other people find this:

const theme = createMuiTheme({
  overrides: {
    MuiTab: {
      textColorInherit: {
        opacity: 1,
      },
    },
  },
});

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
oliviertassinaricommented, Feb 21, 2021

@Dripcoding You can go ahead 🟢

0reactions
Dripcodingcommented, Feb 21, 2021

@oliviertassinari I’d like to work on this issue since it’s been more than a month.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Color Management Tab - SAi Cloud
Color Management Tab ; Angled Screen. Designed for use with thermal printers to produce vibrant, saturated colors. This is also produces screen print...
Read more >
[Tabs] Improve color management #24286 - mui/material-ui
The opacity is used to distinguish between selected and unselected tab. I think that we could do two things: Maybe primary the default...
Read more >
About Color Management - Microsoft Support
Use color management to assign different color profiles to different display devices, creating a uniform color experience across all of your devices.
Read more >
How to use Color management in Fusion Tab - YouTube
This Tutorial Teaches how Color is Approached Fusion Tab. Color Management in Fusion is New to Resolve and to Upgrade your Skills in...
Read more >
Something Look Off on Your Monitor? Tweak These Windows ...
Click Color Management and select the Advanced tab. Select the Calibrate display button and follow the instructions in the Color Calibration ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found