question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[useFocusVisible] Don't trigger when coming back from another window

See original GitHub issue

When I open (click) a link in a new tab using Button and return to the original page, the ripple effect on this button keeps going. Same thing about downloading files. I didn’t use the keyboard ever.

<Fab
  className={styles.link}
  href={cta1Url}
  target={cta1OpenInNewWindow ? '_blank' : ''}
  onClick={() => trackingProvider.trackCtaClick(cta1Text, cta1Type, cta1Url, props.carName, props.mbv)}
  variant="extended"
  color='primary'>
  {cta1Text}
</Fab>

I’m using “@material-ui/core”: “4.11.3”. It happens on Firefox v85 but not Chrome v88. It can be reproduced on https://material-ui.com/, with the “Get started” button link in the hero.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
eps1loncommented, Mar 7, 2021

we don’t ship anything to end-users, developers do.

We do ship to end-users. Every time someone uses our libraries. Developers trust us to make the right decision. They don’t need a library if they have to tell what the library what it’s supposed to do.

Developers give us permission, not the other way around.

They don’t give us permission. They choose a library that solves problems for they want to solve for end users. If they don’t follow web principles then they should choose a different library.

0reactions
eps1loncommented, Jun 18, 2021

Closing as expected behavior.

Read more comments on GitHub >

github_iconTop Results From Across the Web

[useFocusVisible] Don't trigger when coming back from ...
When I open (click) a link in a new tab using Button and return to the original page, the ripple effect on this...
Read more >
:focus-visible and backwards compatibility - TPGi
and it seems that, even just trying to demo this using :-moz-focusring , the following button:focus:not(:-moz-focusring) doesn't work in Firefox ...
Read more >
focus-visible - CSS: Cascading Style Sheets - MDN Web Docs
The :focus-visible pseudo-class applies while an element matches the :focus pseudo-class and the UA (User Agent) determines via heuristics ...
Read more >
Javascript: How to prevent triggering focus on input when ...
Hmm I like the idea of setting donotclear=false when the inputs gets the focus, and not trying to detect when we are coming...
Read more >
focus-visible
Any element which supports keyboard input (such as an input element, or any other element which may trigger a virtual keyboard to be...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found