question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] "atom core" deprecation after Split Diff: Toggle

See original GitHub issue

Here’s the deprecation message:

Assigning editor 260's height explicitly via position: 'absolute' and an assigned top and bottom implicitly assigns the autoHeight property to false on the editor. This behavior is deprecated and will not be supported in the future. Please explicitly assign autoHeight on this editor.

TextEditorComponent.measureDimensions - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:1012:20
TextEditorComponent.becameVisible - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:295:12
TextEditorComponent.checkForVisibilityChange - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:994:16
atom-text-editor.attachedCallback - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:87:22
atom-pane-axis.childAdded - /Applications/Atom.app/Contents/Resources/app.asar/src/pane-axis-element.js:95:12
Function.module.exports.Emitter.simpleDispatch - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:2
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
mupchrchcommented, May 17, 2017

Ugh forgot to comment my findings, sorry @ooJerryLeeoo!

It looks like git-plus is setting up split-diff manually instead of just calling the toggle command. git-plus is feeding two editors directly to one of my API’s and bypassing the split-diff logic that finds the visible editors and splits panes if there aren’t two found side by side (the logic mentioned in atom/atom#13736). This is the logic that is causing the deprecation warning.

1reaction
mupchrchcommented, May 10, 2017

Sorry, glad you asked because I would have forgot to investigate since this issue is closed! Reopening - will hopefully get time to look tonight.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to remove "deprecation" in Atom IDE? - Stack Overflow
The "deprecation" in the bottom corner means that you are using at least two items in your code that are deprecated. To remove...
Read more >
My first week with Atom editor - Andrej Gajdos
nuclide – doesn't entirely work until you upgrade to latest react. split-diff – uncaught exception when using nuclide compare-files – does ...
Read more >
Bug listing with status RESOLVED with resolution UPSTREAM ...
status:RESOLVED resolution:UPSTREAM severity:major · Bug:40457 - "After enabling the OpenGL specturm analyser any atempt to disable it crashes xmms-1.2.9" ...
Read more >
hg - Mercurial SCM
After using this option, hg status -C can be used to check which files were ... With the --switch-parent option, the diff will...
Read more >
Modern IDEs are magic. Why are so many coders still using ...
“Since then it's become a question of 'code speed.' If I start with a new IDE or even switch to something like Emacs,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found