Returns 200 when custom check raises Exception

Describe the bug

Returns 200 when custom check raises Exception on the health service.

To Reproduce

implement a custom check like this:

# in settings file

from watchman import constants as watchman_constants

WATCHMAN_CHECKS = watchman_constants.DEFAULT_CHECKS + (
    "utils.custom_health_checks.db_write_health_check",
)
WATCHMAN_DATABASES = ["default"]

WATCHMAN_ERROR_CODE = 500


# in the utils file
@check
def db_write_health_check():
    raise Exception()

Expected behavior

I expect a non-OK overall response but it gets something like this:

{"storage": {"ok": true}, "ok": false, "error": "", "stacktrace": "Traceback (most recent call last):\n  File \"/home/kiarash/Documents/work/code/iam/bepa2/venv/lib/python3.8/site-packages/watchman/decorators.py\", line 29, in wrapped\n    response = func(*args, **kwargs)\n  File \"/home/kiarash/Documents/work/code/iam/bepa2/src/utils/custom_health_checks.py\", line 19, in db_write_health_check\n    raise Exception()\nException\n", "databases": [{"default": {"ok": true}}], "caches": [{"default": {"ok": true}}]}

Desktop (please complete the following information):

• OS: Ubuntu 20.04
• Python version: 3.8
• Django-watchman version 1.3.0
• Django-watchman settings
• Custom checks

Explained in the Code Sample.

[kiarashazarnia]

Thanks for your attention, yeah… I’m willing to have some contribution and honestly, I have an idea to fix it. I will inform you as soon as I find time to share my idea with you in a PR. I will be happy to be notified if you fix it sooner or have some advice or a contribution guide link for me. Good Luck

[mwarkentin]

I’ve updated the sample project with 2 custom checks (one successful, one failing), I’ll open a separate PR to update the docs on writing custom checks.

I suspect it’s possible to make the @check operator smarter and not need to be wrapped, but I don’t have time to look into that currently. If it’s something you’d be interested in working on, let me know.