SqlSessionFactoryBean falls in circular dependencies by Spring Boot's DataSourceInitializer.

SqlSessionFactoryBean falls in circular dependencies by Spring Boot’s DataSourceInitializer.

With @Lazy annotations it’s okay but without them the following exception occurs:

Caused by: org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'sqlSessionFactory': Requested bean is currently in creation: Is there an unresolvable circular reference?

A project with @Lazy annotations: https://github.com/izeye/samples-spring-boot-branches/tree/mybatis-hsqldb

A project without @Lazy annotations: https://github.com/izeye/samples-spring-boot-branches/tree/mybatis-hsqldb-without-lazy

I guess replacing ApplicationListener<ApplicationEvent> with ApplicationListener<ContextRefreshedEvent> would fix it.

If my usage is incorrect, please let me know.

[dguggi]

I can also reproduce this issue with mybatis-spring-1.2.2, mybatis-3.2.8, spring-boot-1.2.2, spring-4.1.5

My usecase:

• two SqlSessionFactory(Beans) with two (different) @MapperScan (using spring @Configuration classes)

this also leads to the warning message mentioned above: “Requested bean is currently in creation: Is there an unresolvable circular reference?”

I think the problem is in MapperFactoryBean.java (mybatis-spring) and how it is created via the “ClassPathMapperScanner”.

my observations:

• ClassPathMapperScanner creates “GenericBeanDefinition” (in my case for scanned classes that implement a marker interface)
• afterwards org.springframework.beans.factory.support.AbstractBeanFactory.getTypeForFactoryBean() is invoked for every created “GenericBeanDefinition” (that is MapperFactoryBean instances)
• … which actually invokes MapperFactoryBean.getObjectType() and this method returns null (!) (as the setMapperInterface() method seems not to be invoked yet)

I could fix this (using a patched mybatis-spring version) as follows:

Changes to MapperFactoryBean.java

add constructor that takes the mapperinterface as argument:

public MapperFactoryBean2(Class<T> mapperInterface) {
        this.mapperInterface = mapperInterface;
 }

• for backward comp. reasons i also added a default constructor:

public MapperFactoryBean2() {
}

Changes to ClassPathMapperScanner.java

Create GenenericBeanDefinition (in doScan() method) using the new constructur (vs. using setMapperInterface() method):

...
        // the mapper interface is the original class of the bean
        // but, the actual class of the bean is MapperFactoryBean  
definition.getConstructorArgumentValues().addGenericArgumentValue(definition.getBeanClassName());
        // NOTE: the line above replaces the line below...
        //definition.getPropertyValues().add("mapperInterface", definition.getBeanClassName());
        definition.setBeanClass(MapperFactoryBean2.class);
...

Hope this helps and could make it into the next mybatis-spring release (as this resolved our issue).

[emacarron]

You are right! Seems that a later PR changed that lines back. Sorry!

I will remake the change again in master.