Processes and reports false positives for non-project files

Thanks for creating ts-prune, it works really well! It just correctly found 80 unused exports from our project!

One problem that I have though is ts-prune processes some files that are not specified in tsconfig.json’s “include” property, and also reports false positives for those files.

The exports (not unused) that are reported incorrectly are in the path .circleci/ecs-deployment/src/aws.ts and they’re imported from .circleci/ecs-deployment/src/index.ts, in case these file paths are somehow causing the bug.

My tsconfig.json

{
  "compilerOptions": {
    "allowJs": false,
    "jsx": "react",
    "moduleResolution": "node",
    "outDir": "out",
    "sourceMap": true,
    "strictNullChecks": true,
    "noImplicitAny": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noFallthroughCasesInSwitch": true,
    "skipLibCheck": true,
    "target": "es6",
    "module": "commonjs",
    "lib": [
      "dom",
      "es2017"
    ]
  },
  "include": [
    "backend",
    "client",
    "common",
    "migrations",
    "scripts",
    "test",
    "types"
  ]
}

[nadeesha]

Thanks for reporting this @emlai.

If it’s not specified in the tsconfig.json, and if you still want to ignore them, what you outlined in #13 seems like a good option.

I’m putting most of my effort right now in performance improvements. It would be a while before I get to this. However, if you want to do a PR for it, I’m more than happy to guide you through it.

In the meantime, ts-prune | grep -v .circleci/ecs-deployment/src might work for that directory?

[emlai]

@nadeesha Yeah I can confirm 1 is what’s happening. The directory structure looks like this (so e.g. we have a separate tsconfig there):

A file inside .circleci/ecs-deployment/src is being imported from one of the main project files.

If I add .circleci/ecs-deployment to the main tsconfig, then the false positives go away. Adding only .circleci doesn’t work. However, adding .circleci/ecs-deployment to the main tsconfig causes the project to not compile, so we can’t simply do that.

Still, would be nice if there were no false positives reported when we import files not specified in tsconfig.