pytest plugin runs even when irrelevant

Describe the bug pytest plugin runs even when irrelevant.

pytest --help
..
  File "/usr/lib/python3.8/site-packages/nameko/testing/pytest.py", line 80, in pytest_load_initial_conftests
    eventlet.monkey_patch()
  File "/usr/lib/python3.8/site-packages/eventlet/patcher.py", line 271, in monkey_patch
    _green_existing_locks()
  File "/usr/lib/python3.8/site-packages/eventlet/patcher.py", line 362, in _green_existing_locks
    if isinstance(obj, rlock_type):
  File "/usr/lib/python3.8/site-packages/django/utils/functional.py", line 224, in inner
    self._setup()
  File "/usr/lib/python3.8/site-packages/django/conf/__init__.py", line 57, in _setup
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: Requested settings, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.

To Reproduce

1. Install nameko
2. Go to a directory unrelated to nameko
3. run pytest --help

Expected behavior nameko plugin should expose its options, but otherwise do nothing.

Environment (please complete the following information):

• Nameko version: 2.13.0
• Python version: 3.8
• OS: Linux

[palfrey]

Adding addopts = -p no:nameko to my pytest.ini at least worked around this

[mattbennett]

Thanks, you are completely right.

Forcing all users (that run tests) to add something to their project conftest.py would be clunky and jarring for lots of existing users, but I like the idea of moving the monkey-patch to a different library.

It can be automatically included in Nameko’s dev dependencies, and appear as in testing or similar install_extras for folks that want to write tests for their Nameko services.

Thanks again for raising this.